sqlparser: add drop index "lock | algorithm option" #693 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[summary] 1. Add drop index "lock | algorithm option". 2. Refactor lock_algorithm_option in create index. [test case] src/proxy/ddl_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ddl_test.go [patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.2% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 95.4% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 69.6%
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
=====================================
- Coverage 89% 89% -1%
=====================================
Files 130 130
Lines 9279 9279
=====================================
- Hits 8269 8267 -2
- Misses 669 670 +1
- Partials 341 342 +1
Continue to review full report at Codecov.
|
zhyass
reviewed
Oct 29, 2020
zhyass
reviewed
Oct 29, 2020
zhyass
reviewed
Oct 29, 2020
zhyass
reviewed
Oct 29, 2020
zhyass
reviewed
Oct 29, 2020
|
Is there something wrong with the original code? If it is just to be consistent with the implementation of mysql, and the original implementation result is no problem, I think there is no need to modify it. |
zhyass
reviewed
Nov 12, 2020
hustjieke
force-pushed
the
feature_complete_drop_index_option_#693
branch
from
e767925 to
c4de3c0
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[summary]
[test case]
src/proxy/ddl_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ddl_test.go
[patch codecov]
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.2%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 95.4%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go 69.6%