Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] support CHECK TABLE Statement #718

Closed
hustjieke opened this issue Jan 11, 2021 · 0 comments
Closed

[feature] support CHECK TABLE Statement #718

hustjieke opened this issue Jan 11, 2021 · 0 comments
Assignees
@hustjieke
Labels
P0 High priority type: feature

Comments

@hustjieke
Copy link
Contributor

MySQL 8.0 syntax:

CHECK TABLE tbl_name [, tbl_name] ... [option] ...

option: {
    FOR UPGRADE
  | QUICK
  | FAST
  | MEDIUM
  | EXTENDED
  | CHANGED
}

Actually, the key word "TABLE" should be "TABLE | TABLES", so radondb will support syntax next:

CHECK {TABLE | TABLES} tbl_name [, tbl_name] ... [option] ...

option: {
    FOR UPGRADE
  | QUICK
  | FAST
  | MEDIUM
  | EXTENDED
  | CHANGED
}
@hustjieke hustjieke added type: feature P0 High priority labels Jan 11, 2021
@hustjieke hustjieke self-assigned this Jan 11, 2021
hustjieke added a commit to hustjieke/radon that referenced this issue Jan 11, 2021
@hustjieke
*.:support check table stmt radondb#718
cf3541f
hustjieke added a commit to hustjieke/radon that referenced this issue Jan 19, 2021
@hustjieke
*.:support check table stmt radondb#718
f337422 
[summary]
support check stmt:

```
CHECK {TABLE | TABLES} tbl_name [, tbl_name] ... [option] ...

option: {
    FOR UPGRADE
  | QUICK
  | FAST
  | MEDIUM
  | EXTENDED
  | CHANGED
}
```

[test case]
sqlparser/parse_test.go
src/planner/others_plan_test.go
src/proxy/table_maintenance_test.go

[patch codecov]
src/planner/others_plan.go  94.9%
src/proxy/table_maintenance.go 100%
src/proxy/query.go  94.8%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go  87.5%
hustjieke added a commit to hustjieke/radon that referenced this issue Jan 19, 2021
@hustjieke
*.:support check table stmt radondb#718
e6bb0c3 
[summary]
support check stmt:

```
CHECK {TABLE | TABLES} tbl_name [, tbl_name] ... [option] ...

option: {
    FOR UPGRADE
  | QUICK
  | FAST
  | MEDIUM
  | EXTENDED
  | CHANGED
}
```

[test case]
sqlparser/parse_test.go
src/planner/others_plan_test.go
src/proxy/table_maintenance_test.go

[patch codecov]
src/planner/others_plan.go  94.9%
src/proxy/table_maintenance.go 100%
src/proxy/query.go  94.8%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go  87.5%
hustjieke added a commit to hustjieke/radon that referenced this issue Jan 19, 2021
@hustjieke
proxy: fix wrong word radondb#718
eaf3d40 
[summary]
fix word "optimize" to "check"
fix word "note" to "status"

[test case]
N/A

[patch codecov]
N/A
BohuTANG added a commit that referenced this issue Jan 20, 2021
@BohuTANG
Merge pull request #723 from hustjieke/feature_support_check_table_stmt
9c0186b 
*.:support check table stmt #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hustjieke hustjieke

Labels
P0 High priority type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hustjieke