*.:support check table stmt #718 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[summary]
support check stmt:
```
CHECK {TABLE | TABLES} tbl_name [, tbl_name] ... [option] ...
option: {
FOR UPGRADE
| QUICK
| FAST
| MEDIUM
| EXTENDED
| CHANGED
}
```
[test case]
sqlparser/parse_test.go
src/planner/others_plan_test.go
src/proxy/table_maintenance_test.go
[patch codecov]
src/planner/others_plan.go 94.9%
src/proxy/table_maintenance.go 100%
src/proxy/query.go 94.8%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 87.5%
hustjieke
force-pushed
the
feature_support_check_table_stmt
branch
from
f337422 to
e6bb0c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=====================================
Coverage 89% 89%
=====================================
Files 133 133
Lines 9370 9406 +36
=====================================
+ Hits 8364 8400 +36
Misses 665 665
Partials 341 341
Continue to review full report at Codecov.
|
[summary] fix word "optimize" to "check" fix word "note" to "status" [test case] N/A [patch codecov] N/A
|
LGTM |
andyli029
reviewed
Jan 20, 2021
| @@ -252,3 +252,31 @@ var OptimizeOption2Str = map[OptimizeOptionEnum]string{ | |||
| OptimizeOptionNoWriteToBinlog: "no_write_to_binlog", | |||
| OptimizeOptionLocal: "local", | |||
| } | |||
|
|
|||
| // CheckOptionEnum is an enum for optimize statement. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[summary]
support check stmt:
[test case]
sqlparser/parse_test.go
src/planner/others_plan_test.go
src/proxy/table_maintenance_test.go
[patch codecov]
src/planner/others_plan.go 94.9%
src/proxy/table_maintenance.go 100%
src/proxy/query.go 94.8%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 87.5%