Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rock 3a rock 3a sata #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add rock 3a rock 3a sata #112

wants to merge 2 commits into from

Conversation

nascs
Copy link
Contributor

@nascs nascs commented Sep 14, 2024

No description provided.

@nascs nascs requested a review from RadxaYuntian as a code owner September 14, 2024 12:05
@nascs
Copy link
Contributor Author

nascs commented Sep 14, 2024

radxa/u-boot/pull/95

RadxaYuntian
RadxaYuntian reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动在最新的rockchip uboot里面有么？

@nascs
Copy link
Contributor Author

nascs commented Dec 19, 2024

这个改动在最新的rockchip uboot里面有么？

都有的

https://github.com/radxa/u-boot/blob/next-dev-v2024.10/arch/arm/dts/rk3568-rock-3a-sata.dts
https://github.com/radxa/u-boot/blob/9e797b750b4360abf1eeaa948543b12a5b1d5117/arch/arm/dts/rk3568-rock-3a.dts#L427
https://github.com/radxa/u-boot/blob/next-dev-v2024.10/configs/rock-3a-sata-rk3568_defconfig

@nascs
Copy link
Contributor Author

nascs commented Dec 19, 2024

这个改动在最新的rockchip uboot里面有么？

要加一个 rk2410 的吧？

RadxaYuntian
RadxaYuntian requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只在rk2410上支持，我们不会在3a上使用rknext了

nascs added 2 commits December 19, 2024 17:27
@nascs
feat: u-boot: rk2410: add rock-3a support
5d07287 
Signed-off-by: Nascs Fang <nascs@radxa.com>
@nascs
feat: u-boot: rk2410: add rock-3a-sata support
09659a5 
Signed-off-by: Nascs Fang <nascs@radxa.com>
@nascs nascs force-pushed the add_rock-3a_rock-3a-sata branch from 2dde14c to 09659a5 Compare December 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadxaYuntian RadxaYuntian RadxaYuntian requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nascs @RadxaYuntian