Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rock-3a m.2 e-key sata dts and defconfig #95

Conversation

pykpkg47
Copy link

@pykpkg47 pykpkg47 commented Sep 6, 2024

Added dts for rock-3a which switches m.2 e-key to sata and a defconfig which enables the needed options for sata

Tested with m.2 sata ssd , boot works if first partition(/boot) is vfat

depends on #94 which has to be merged first

pykpkg47 and others added 2 commits September 5, 2024 11:37
Signed-off-by: pykpkg47 <pykpkg@protonmail.com>
Signed-off-by: pykpkg47 <pykpkg@protonmail.com>
@nascs
Copy link

nascs commented Sep 14, 2024

Hi @pykpkg47, please add the following configs:

CONFIG_SATA=y
CONFIG_CMD_SATA=y
CONFIG_SYS_SCSI_MAX_SCSI_ID=1
CONFIG_SYS_SCSI_MAX_LUN=1

@nascs
Copy link

nascs commented Sep 14, 2024

Hi @pykpkg47, please add the following configs:

CONFIG_SATA=y CONFIG_CMD_SATA=y CONFIG_SYS_SCSI_MAX_SCSI_ID=1 CONFIG_SYS_SCSI_MAX_LUN=1

  1. you need open sata driver by the config "CONFIG_SATA=y"
  2. "CONFIG_CMD_SATA=y" enables this configuration option, which is beneficial for debugging SATA devices on U-Boot

@nascs
Copy link

nascs commented Sep 14, 2024

Hi @pykpkg47, please add the following configs:
CONFIG_SATA=y CONFIG_CMD_SATA=y CONFIG_SYS_SCSI_MAX_SCSI_ID=1 CONFIG_SYS_SCSI_MAX_LUN=1

  1. you need open sata driver by the config "CONFIG_SATA=y"
  2. "CONFIG_CMD_SATA=y" enables this configuration option, which is beneficial for debugging SATA devices on U-Boot
  1. The other two settings are conducive to the more efficient initialization and management of available devices in the system.

@nascs
Copy link

nascs commented Sep 14, 2024

Certainly, "CONFIG_CMD_SATA=y" is an optional configuration option.

@pykpkg47
Copy link
Author

added the configs , build u-boot without error, will test later on device

@pykpkg47
Copy link
Author

Tested with added config options sata boot still works

@nascs
Copy link

nascs commented Sep 18, 2024

Tested with added config options sata boot still works

I tested just now, it works too.

@RadxaStephen
Copy link
Member

RadxaStephen commented Sep 18, 2024

diff --git a/configs/rock-3a-sata-rk3568_defconfig b/configs/rock-3a-sata-rk3568_defconfig
new file mode 100644
index 00000000000..dd6cd68fa66
--- /dev/null
+++ b/configs/rock-3a-sata-rk3568_defconfig
@@ -0,0 +1,239 @@
+CONFIG_ARM=y^M
+CONFIG_ARCH_ROCKCHIP=y^M
+CONFIG_SPL_LIBCOMMON_SUPPORT=y^M
+CONFIG_SPL_LIBGENERIC_SUPPORT=y^M

@pykpkg47

Hi. I can see that there is ^M at the end of each line in file rk3568-rock-3a-sata.dts and rock-3a-sata-rk3568_defconfig.
Please remove the ^M.

@pykpkg47 pykpkg47 force-pushed the next-dev-v2024.03-rock3a-sata-boot branch from 7a35264 to 58a94c6 Compare September 18, 2024 12:43
@pykpkg47
Copy link
Author

done changed carriage returns to Line Feed (though git in vscode does that themself but was wrong)

@RadxaStephen
Copy link
Member

Thanks. I see that rock-3a-sata-rk3568_defconfig is correct. Please also modify file dts rk3568-rock-3a-sata.dts.

Signed-off-by: pykpkg47 <pykpkg@protonmail.com>
@pykpkg47 pykpkg47 force-pushed the next-dev-v2024.03-rock3a-sata-boot branch from 58a94c6 to fda58fc Compare September 18, 2024 17:44
@RadxaStephen
Copy link
Member

Please rewrite these two commits.

  1. 464932b

Remove ^M

  1. fda58fc

Remove rk3568-rock-3a-sata.dts from this commit since this commit is for rock 3a sata defconfig.

@RadxaStephen
Copy link
Member

RadxaStephen commented Oct 9, 2024

I rewrite the pr and merge it.

@pykpkg47 Thanks for your great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants