Download Button Disappears #3396

elipe17 · 2025-01-01T16:05:39Z

Summary of Changes

Fixed logic causing download button to disappear
Also made small update to PR template to better align with our local dev/test flow
Pull request closes Fix download button disappearance after click #2175

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up

Open http://localhost:3000/ and sign in.
Submit some files
Download your uploaded files
Verify the download button doesn't disappear

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Download buttons do not disappear when clicked
Download buttons do not appear when no file is present for that section
Testing Checklist has been run and all tests pass
README is updated, if necessary

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- If this PR introduces backend code changes, are they meaningfully tested?
- If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

Are backend code style checks passing on CircleCI?
Are frontend code style checks passing on CircleCI?
Are code maintainability principles being followed?

Deliverable 4: Accessible

Does this PR complete the epic?
Are links included to any other gov-approved PRs associated with epic?
Does PR include documentation for Raft's a11y review?
Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Does this PR provide background for why coding decisions were made?
If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces dependencies, are their licenses documented?
Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

Does the OWASP Scan pass on CircleCI?
Do manual code review and manual testing detect any new security issues?
If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

the purpose of the research
methods used to conduct the research
who participated in the research
what was tested and how
impact of research on TDP
(if applicable) final design mockups produced for TDP development

elipe17 · 2025-01-01T17:17:07Z

tdrs-backend/tdpservice/parsers/validators/test/test_category3.py

    ),
    (
        '202010', 18, {}, False,
-        '2020 must be less than or equal to 2006 to meet the minimum age requirement.'
+        '2020 must be less than or equal to 2007 to meet the minimum age requirement.'


This needed an update since it is now officially 1/1/2025!

can we make this dynamic so we don't run into test issues in the future?

also, this affects a lot (all?) of the other open PRs. might be worth making it its own hotfix

codecov · 2025-01-01T17:43:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (d516f2d) to head (396c3a6).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3396   +/-   ##
========================================
  Coverage    91.45%   91.45%           
========================================
  Files          299      299           
  Lines         8605     8605           
  Branches       638      638           
========================================
  Hits          7870     7870           
  Misses         617      617           
  Partials       118      118

Flag	Coverage Δ
dev-backend	`91.32% <ø> (ø)`
dev-frontend	`92.44% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...-frontend/src/components/FileUpload/FileUpload.jsx	`92.59% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0323d47...396c3a6. Read the comment docs.

raftmsohani

LGTM!

jtimpe

Button fix works. Suggestion on the test update

jtimpe · 2025-01-06T16:02:40Z

.github/pull_request_template.md

-cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
-cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
+cd tdrs-frontend && docker-compose up --build
+cd tdrs-backend && docker-compose up --build


thank you 🥇

jtimpe · 2025-01-06T16:03:15Z

tdrs-backend/tdpservice/parsers/validators/test/test_category3.py

    ),
    (
        '202010', 18, {}, False,
-        '2020 must be less than or equal to 2006 to meet the minimum age requirement.'
+        '2020 must be less than or equal to 2007 to meet the minimum age requirement.'


can we make this dynamic so we don't run into test issues in the future?

jtimpe · 2025-01-06T16:05:22Z

tdrs-backend/tdpservice/parsers/validators/test/test_category3.py

    ),
    (
        '202010', 18, {}, False,
-        '2020 must be less than or equal to 2006 to meet the minimum age requirement.'
+        '2020 must be less than or equal to 2007 to meet the minimum age requirement.'


also, this affects a lot (all?) of the other open PRs. might be worth making it its own hotfix

jtimpe · 2025-01-06T17:15:46Z

tdrs-backend/tdpservice/parsers/validators/test/test_category3.py

    ),
    (
        '202010', 18, {}, False,
-        '2020 must be less than or equal to 2006 to meet the minimum age requirement.'
+        '2020 must be less than or equal to 2007 to meet the minimum age requirement.'


elipe17 added 2 commits January 1, 2025 10:58

- Fixed logic causing download button to disappear

1439aee

- Updating to align with what devs actually do

6846a01

elipe17 added bug frontend dev raft review This issue is ready for raft review a11y-review PR is ready for accessibility review labels Jan 1, 2025

elipe17 requested review from reitermb, andrew-jameson, raftmsohani, victoriaatraft and jtimpe January 1, 2025 16:05

elipe17 self-assigned this Jan 1, 2025

- Updated test due to new year

0d435d3

elipe17 commented Jan 1, 2025

View reviewed changes

raftmsohani approved these changes Jan 2, 2025

View reviewed changes

Merge branch 'develop' into 2175-download-button

0259c7a

jtimpe approved these changes Jan 6, 2025

View reviewed changes

Merge branch 'develop' into 2175-download-button

396c3a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download Button Disappears #3396

Download Button Disappears #3396

elipe17 commented Jan 1, 2025 •

edited

Loading

elipe17 Jan 1, 2025

jtimpe Jan 6, 2025

jtimpe Jan 6, 2025

jtimpe Jan 6, 2025

codecov bot commented Jan 1, 2025 •

edited

Loading

raftmsohani left a comment

jtimpe left a comment

jtimpe Jan 6, 2025

jtimpe Jan 6, 2025

jtimpe Jan 6, 2025

jtimpe Jan 6, 2025

Download Button Disappears #3396

Are you sure you want to change the base?

Download Button Disappears #3396

Conversation

elipe17 commented Jan 1, 2025 • edited Loading

Summary of Changes

How to Test

Deliverables

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 1, 2025 • edited Loading

Codecov Report

raftmsohani left a comment

Choose a reason for hiding this comment

jtimpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elipe17 commented Jan 1, 2025 •

edited

Loading

codecov bot commented Jan 1, 2025 •

edited

Loading