-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Button Disappears #3396
base: develop
Are you sure you want to change the base?
Changes from 4 commits
1439aee
6846a01
0d435d3
0259c7a
396c3a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,6 @@ def _make_eargs(val): | |
|
||
def _validate_and_assert(validator, val, exp_result, exp_message): | ||
result, msg = validator(val, _make_eargs(val)) | ||
print(f'result: {result}; msg: {msg}') | ||
assert result == exp_result | ||
assert msg == exp_message | ||
|
||
|
@@ -223,11 +222,11 @@ def test_isNotZero(val, number_of_zeros, kwargs, exp_result, exp_message): | |
('199510', 18, {}, True, None), | ||
( | ||
f'{datetime.date.today().year - 18}01', 18, {}, False, | ||
'2006 must be less than or equal to 2006 to meet the minimum age requirement.' | ||
'2007 must be less than or equal to 2007 to meet the minimum age requirement.' | ||
), | ||
( | ||
'202010', 18, {}, False, | ||
'2020 must be less than or equal to 2006 to meet the minimum age requirement.' | ||
'2020 must be less than or equal to 2007 to meet the minimum age requirement.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needed an update since it is now officially 1/1/2025! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we make this dynamic so we don't run into test issues in the future? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also, this affects a lot (all?) of the other open PRs. might be worth making it its own hotfix There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
), | ||
]) | ||
def test_isOlderThan(val, min_age, kwargs, exp_result, exp_message): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 🥇