Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Button Disappears #3396

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Pull request closes #_
_List the steps to test the PR_
These steps are generic, please adjust as necessary.
```
cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-frontend && docker-compose up --build
cd tdrs-backend && docker-compose up --build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🥇

```

1. Open http://localhost:3000/ and sign in.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ def _make_eargs(val):

def _validate_and_assert(validator, val, exp_result, exp_message):
result, msg = validator(val, _make_eargs(val))
print(f'result: {result}; msg: {msg}')
assert result == exp_result
assert msg == exp_message

Expand Down Expand Up @@ -223,11 +222,11 @@ def test_isNotZero(val, number_of_zeros, kwargs, exp_result, exp_message):
('199510', 18, {}, True, None),
(
f'{datetime.date.today().year - 18}01', 18, {}, False,
'2006 must be less than or equal to 2006 to meet the minimum age requirement.'
'2007 must be less than or equal to 2007 to meet the minimum age requirement.'
),
(
'202010', 18, {}, False,
'2020 must be less than or equal to 2006 to meet the minimum age requirement.'
'2020 must be less than or equal to 2007 to meet the minimum age requirement.'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed an update since it is now officially 1/1/2025!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this dynamic so we don't run into test issues in the future?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this affects a lot (all?) of the other open PRs. might be worth making it its own hotfix

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

),
])
def test_isOlderThan(val, min_age, kwargs, exp_result, exp_message):
Expand Down
2 changes: 1 addition & 1 deletion tdrs-frontend/src/components/FileUpload/FileUpload.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ function FileUpload({ section, setLocalAlertState }) {
data-errormessage={INVALID_FILE_ERROR}
/>
<div style={{ marginTop: '25px' }}>
{hasFile && selectedFile?.id ? (
{hasFile && selectedFile?.uuid ? (
<Button
className="tanf-file-download-btn"
type="button"
Expand Down
Loading