Having attribute :name in a serializer causes exceptions

[whatthewhat]

Having attribute :name in a serializer breaks with NoMethodError: undefined method 'name' for #<AuthorSerializer:0x007ffe5afe6810>.
But attributes :id, :name works..

I've changed one of the test serializers to demonstrate the issue.

I'll try to find time later to investigate some more, unless there is not an obvious fix someone could point me to.

[beauby]

Could you state the version and adapter that lead to the error?

[whatthewhat]

@beauby should be clear from the tests when (if) they fail.

The error reproduces on master, the serializer is super simple:

class CompanySerializer < ActiveModel::Serializer
  attribute :id
  attribute :name
end

[beauby]

Sure, but which adapter? (json, flatten_json, json_api?)

[whatthewhat]

@beauby oh, sorry :) json

[whatthewhat]

Looking at the test failures seems like it's universal for all adapters

[beauby]

Investigating!

[beauby]

Found the cause, but no fix yet.
In attributes we call method_defined?(attr), and in attribute we call respond_to?(key, false). I'm not sure about the rationale behind it, but replacing respond_to?(key, false) with method_defined?(key) messes with the ability of overriding the id attribute.
@joaomdmoura @bf4 ideas?

[beauby]

Hmm actually it's no surprise overriding id fails in that case because of this. @joaomdmoura what's the reason for this id method?

[kayhide]

#method_defined? is for a class and looks for a instance method.
#respond_to? is for a object and looks for a method of the receiver object.

So this returns whether the class method exists or not.
This does not check instance methods.

In this case, we are interested in instance methods, so #method_defined? is good to do that.

[beauby]

Thanks a lot for the clarification @kayhide!