Fix definition of serializer attributes with multiple calls to `attri… #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute` instead of one single call to `attributes`.
| @@ -70,7 +70,7 @@ def self.attribute(attr, options = {}) | |||
| ActiveModelSerializers.silence_warnings do | |||
| define_method key do | |||
| object.read_attribute_for_serialization(attr) | |||
| end unless respond_to?(key, false) || _fragmented.respond_to?(attr) | |||
| end unless (key != :id && method_defined?(key)) || _fragmented.respond_to?(attr) | |||
There was a problem hiding this comment.
looks like this should be extracted to a helper method for readability
There was a problem hiding this comment.
While we're at it, should _fragmented.respond_to?(attr) not be _fragmented.respond_to?(key)? I haven't delved into the caching yet.
|
👍 |
1 similar comment
|
👍 |
|
Nice @beauby, I'm merging it, Tks! 😄 |
joaomdmoura
added a commit
that referenced
this pull request
Sep 1, 2015
Fix definition of serializer attributes with multiple calls to `attri…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bute
instead of one single call toattributes`.Fixes #1094.