Add windows platform to loading sqlite3 to make testing suite pass, which caused by #1105 #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Guo
force-pushed
the
master
branch
3 times, most recently
from
34662f8 to
850c1f8
Compare
|
I do several time, seems ruby 200 fail is random, eIther x86/x64, guess a problem of Windows, not relative with AWS |
|
Nice @Eric-Guo tks! I'm merging it. |
| @@ -40,5 +40,5 @@ end | |||
| gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby] | |||
|
|
|||
| group :development, :test do | |||
| gem 'rubocop', '~> 0.33.0', require: false | |||
| gem 'rubocop', '~> 0.34.0', require: false | |||
There was a problem hiding this comment.
@bf4 @joaomdmoura because rubocop release this version and seems no break change between 0.33 and 0.34.
😄
joaomdmoura
added a commit
that referenced
this pull request
Sep 7, 2015
Add windows platform to loading sqlite3
| @@ -27,7 +27,7 @@ end | |||
|
|
|||
| group :test do | |||
| gem 'activerecord' | |||
| gem 'sqlite3', platform: :ruby | |||
| gem 'sqlite3', platform: [:ruby, :mingw, :x64_mingw, :mswin] | |||
There was a problem hiding this comment.
Are mingw and x64_mingw not included in mswin?
There was a problem hiding this comment.
They are using different compiler, (mswin using Visual C++), (mingw using GCC) but should be included in all mswin, so writing mswin should enough here, although I don't known why Rails still using all of them, guess the history reason of rubygems, but not check yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.