Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows platform to loading sqlite3 to make testing suite pass, which caused by #1105 #1120

Merged
merged 1 commit into from
Sep 7, 2015
Merged

Add windows platform to loading sqlite3 to make testing suite pass, which caused by #1105 #1120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ end

group :test do
gem 'activerecord'
gem 'sqlite3', platform: :ruby
gem 'sqlite3', platform: [:ruby, :mingw, :x64_mingw, :mswin]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are mingw and x64_mingw not included in mswin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are using different compiler, (mswin using Visual C++), (mingw using GCC) but should be included in all mswin, so writing mswin should enough here, although I don't known why Rails still using all of them, guess the history reason of rubygems, but not check yet.

gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
gem 'codeclimate-test-reporter', require: false
end
Expand All @@ -40,5 +40,5 @@ end
gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]

group :development, :test do
gem 'rubocop', '~> 0.33.0', require: false
gem 'rubocop', '~> 0.34.0', require: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change to the Rubocop version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eric-Guo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bf4 @joaomdmoura because rubocop release this version and seems no break change between 0.33 and 0.34.

😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😄

end