Get tests passing on Rails 5 #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are in caching. Help, anyone? ref:
cc @kurko @guilleiguaran @joaomdmoura @spastorino @thibaudgg removed commits that may be interesting |
bf4
force-pushed
the
get_tests_running_on_rails_master
branch
2 times, most recently
from
d043106 to
8789370
Compare
|
ref: #1303 |
bf4
force-pushed
the
get_tests_running_on_rails_master
branch
7 times, most recently
from
ebb5c6e to
a84ec92
Compare
| before_action { request.format = :json } | ||
| else | ||
| before_filter { request.format = :json } | ||
| end |
There was a problem hiding this comment.
I believe before_action already exists in rails4.
There was a problem hiding this comment.
yeah, but not in all versions
Also - Add reference to config from ActiveModelSerializers.config - correctly call super in FragmentCacheTest#setup - rename test rails app from Foo to ActiveModelSerializers::RailsApplication
kwargs: params,session,flash,method,body Fix Rails 5 DEPRECATION WARNING
bf4
force-pushed
the
get_tests_running_on_rails_master
branch
from
1cc83f1 to
e6b248d
Compare
bf4
force-pushed
the
get_tests_running_on_rails_master
branch
from
e6b248d to
6588dee
Compare
bf4
added a commit
that referenced
this pull request
Nov 26, 2015
…ster Get tests passing on Rails 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having trouble with caching tests. Help?