Adding Fragment Cache to AMS #810

joaomdmoura · 2015-02-12T17:50:30Z

It's an upgrade based on the new Cache implementation #693.
Referenced: #802

It allows to use the Rails conventions to cache specific attributes or associations, as you will see in the example ahead.

It's optimized to re-use the cache in ever way as possible, in order to do this, the cached data will shared and resued on different methods, also the Serializers that are cached will be used when referenced as relationship at other serializer.

If there is some API endpoint that shouldn't be fully cached, you can still optimise it, using Fragment Cache on the attributes and relationships that you want to cache.

You can define the attributes by using only or except option on cache mehtod.

Example:

class PostSerializer < ActiveModel::Serializer
  cache key: 'post', expires_in: 3.hours, only: [:title]
  attributes :title, :body

  has_many :comments

  url :post
end

It also work when defining a key to an attribute, in this case you should use the original name of the attribute (no worries, the key still will work):

AlternateBlogSerializer = Class.new(ActiveModel::Serializer) do
  cache only: [:name]
  attribute :id
  attribute :name, key: :title
end

joaomdmoura · 2015-02-12T18:00:04Z

@kurko and it's alive ;) made with ❤️
Tests passing, Rebased, Squashed 👍
Ps. @guilleiguaran so... Rails 5? hahaha 😄

kurko · 2015-02-12T21:26:00Z

README.md

@@ -294,6 +295,25 @@ On this example every ```Post``` object will be cached with
 the key ```"post/#{post.id}-#{post.updated_at}"```. You can use this key to expire it as you want,
 but in this case it will be automatically expired after 3 hours.

+### Fragmenting Caching
+
+If there is some API endpoint that shouldn't be fully cached, you can still optmize it, using Fragment Cache on the attributes and relationships that you want to cache.


Typo, optime.

guilleiguaran · 2015-02-12T21:49:04Z

/cc @spastorino

joaomdmoura · 2015-02-12T22:19:06Z

@kurko, Updated, thank you for the review! Just let me know if you find anything else.

kurko · 2015-02-13T13:47:49Z

lib/active_model/serializer/adapter.rb

 module ActiveModel
  class Serializer
    class Adapter
      extend ActiveSupport::Autoload
+      include ActiveModel::Serializer::Cache


So, my suggestion was to really move the code out of the former class. Instead, you just moved it to a new file, but the code is still inside the Adapter.

In my opinion, the main problem with this approach is that you can't unit test the code you added, but only have integration tests, which aren't really good for refactoring the code later. My suggestion was to use composition, or in other words, call the cache class such as:

def cached_object CachedResource.new(serializer).load end

With that, you can unit test CachedResource separately. Besides that, the adapter has a huge amount of methods doing things that are not the adapter's responsibility.

What do you think? cc @guilleiguaran

Got it. Indeed. Serialization_test is getting too big.

Besides that, the adapter has a huge amount of methods doing things that are not the adapter's responsibility.

Convinced me

@kurko, to avoid performance loss I'll just remove the fragment cache logic, that correspond for 90% of all code, agreed?:

def cached_object klass = serializer.class if klass._cache && !klass._cache_only && !klass._cache_except _cache_key = (klass._cache_key) ? "#{klass._cache_key}/#{serializer.object.id}-#{serializer.object.updated_at}" : serializer.object.cache_key klass._cache.fetch(_cache_key, klass._cache_options) do yield end elsif klass._cache_only && !klass._cache_except || !klass._cache_only && klass._cache_except FragmentCache.new(self, serializer, @options, @root).fetch else yield end end

There will be no other private method (related to cache) than cache_object. It will avoid pass blocks across function and keep it concise. What you think?

Sounds good, that's a good start. I don't think, though, that another class will result in any significant loss.

On another not, I think we need to name things better here; we need to better group the code. For instance, I have no idea from a glance what the following is:

klass._cache_only && !klass._cache_except || !klass._cache_only && klass._cache_except

I'd rather have

def cached_object # ... elsif fragment_cache? FragmentCache.new(self, serializer, @options, @root).fetch else #... end private def fragment_cache? klass._cache_only && !klass._cache_except || !klass._cache_only && klass._cache_except end

The loss would result of passing the yield block to order functions. But yeah it's nothing big.

Agreed. Even cached_object isn't a good name, I'm working on this too.

joshsmith · 2015-02-16T21:24:18Z

@joaomdmoura what can I do to help here?

thibaudgg · 2015-02-18T15:57:31Z

@joaomdmoura looks awesome. 😍
One question, will fetch_multi be supported in the future? It would be really useful (and faster!) for fetching collection or association from cache in one read. 💨
Thanks!

joaomdmoura · 2015-02-18T16:48:41Z

@joshsmith tks man, but there are just some details missing, I'm working on it already 😄 but there are some improvements that I would like to work on in the near future that you can focus too, like the @thibaudgg suggestion.

@thibaudgg Tks! Unfortunately the new cache feature does not use fetch_multi. But it's a great suggestion! It's more related with my last PR #693 adding the new cache feature, if you read this PR you will realize that I cache each object separately. Indeed change the way the Adapter works when retrieving an cached collection to use fetch_multi could be an improvement, maybe also a great opportunity to start benchmarking AMS features.

thibaudgg · 2015-02-19T08:22:07Z

@joaomdmoura fetch_multi support would be a big plus against jbuilder and jbuilder_cache_multi! Thanks.

joaomdmoura · 2015-02-21T00:48:14Z

@kurko, It's done.

Extracted the fragment logic to a new class FragmentCache
Refactored some code from Cache Support at AMS 0.10.0 #693
Wrote some tests related to FragmentCache

joshsmith · 2015-02-21T00:48:50Z

🍻

kurko · 2015-02-23T14:48:31Z

Great work here, @joaomdmoura! Before merging, I want to spend more time with it. I'll deploy it to our staging env and see how it behaves and whether I can catch bugs or not. I'd advise you doing the same over there :D

kurko · 2015-02-23T15:11:14Z

lib/active_model/serializer/fragment_cache.rb

+
+        serializers = {cached: cached, non_cached: non_cached}
+        cached_attributes_and_association(klass, serializers)
+        return serializers


There's no need for this return.

Yeah, I know, I just felt that I should make it explicitly.
Never mind I'm removing it. 😝

joaomdmoura · 2015-03-02T23:36:36Z

lib/active_model/serializer/adapter.rb

@@ -32,8 +35,36 @@ def self.adapter_class(adapter)
        "ActiveModel::Serializer::Adapter::#{adapter.to_s.classify}".safe_constantize
      end

+      def fragment_cache(*args)


@kurko abstracted method. Duck typing strategy.

thibaudgg · 2015-03-23T08:40:35Z

👍

brancusi · 2015-03-23T22:23:34Z

Nice!

kurko · 2015-03-24T19:32:09Z

I tried this in an app and couldn't make it work. Basically, when I add cache only: [:name] to my serializer, I get this:

  1) Error:
UsersTest::GET /users/{id}#test_0001_returns a user by id:
NoMethodError: undefined method `my_virtual_attribute' for #<User:0x0000011126d1c8>
    app/controllers/users_controller.rb:6:in `show'
    test/test_helper.rb:50:in `get'
    my_app_test_path_test.rb:346:in `block (4 levels) in <class:UsersTest>'

My serializer is like this:

class UserSerializer < ActiveModel::Serializer
  cache only: [ :name ]

  attributes :id,
             :name,
             :my_virtual_attribute

  def my_virtual_attribute
    :some_custom_value
  end
end

If I leave cache out, it works fine. I tested against f7fc56f. For your reference, the PR that adds support for virtual associations (not attributes) is #792.

When fixing, please make sure that both virtual attributes and associations are working.

Great work, by the way.

kurko · 2015-03-26T15:43:56Z

Needs to be rebased 😬

joaomdmoura · 2015-03-27T07:23:36Z

@kurko fixed, new tests written, rebased and squashed. 😄

kurko · 2015-04-01T01:38:48Z

FYI, I'm trying to backport this PR into a fork that supports RC1 so I can test this in my app. If it works there, I'll merge it. This is so central to AMS; it has to work perfectly.

kurko · 2015-04-02T03:02:26Z

lib/active_model/serializer/adapter.rb

      private

+      def cache_check(serializer)
+        @serializer = serializer


This mutation is breaking a test in https://github.com/ride/active_model_serializers/blob/master-rc1-with-fragment-cache/test/action_controller/json_api_linked_test.rb#L146-L150 (it's a branch which I'm backporting this into RC1 because that's what my company is using).

Basically, halfway through the serialization (within a execution of serializable_hash), @serializer, which was PostSerializer, becomes AuthorSerializer after this. That same test is passing in this PR, so I'm not really sure what's going on, but regardless of that, mutating a variable that's used to figure out how to serialize stuff is bad and can lead to nasty behaviors in the future. If we're going to mutate, we need to simply instantiate a new object then or make sure the serialization has finished.

@joaomdmoura if you're available, let's discuss this over chat :)

It's an upgrade based on the new Cache implementation rails-api#693. It allows to use the Rails conventions to cache specific attributes or associations. It's based on the Cache Composition implementation.

kurko · 2015-04-05T23:55:07Z

@joaomdmoura first of all, great work here! This got better and better every iterations. I tried this in my app and tests are green 😁

Update: here are the numbers I got:

               user        system    total     real
no cache       21.550000   1.820000  23.370000 ( 28.894494)
cache          16.870000   1.580000  18.450000 ( 21.429540)
fragment cache 22.270000   1.810000  24.080000 ( 28.504920)

(cache means `only: []` wasn't used in the serializer)

joaomdmoura · 2015-04-06T18:44:20Z

Great @kurko
I'm really glad we pulled it off.
The benchmark issue ( #832 ) now would be awesome, btw I'm already working on it.
The cache obviously improved overall performance.

I'm sad about the fragment cache result, but as we discussed it would be really useful for attributes that involves some kind of logic, as virtual attributes on the serializer itself. Would be great to benchmark this case too 😄

But there is some improvement we can work on to optimize fragment cache speed, once benchmark tests are done will be way easier to keep track of it.

kurko · 2015-04-06T19:19:04Z

Awesome. I'm testing it and if I don't find issues in a day or two, I'll merge this 😄

Catalectic · 2015-04-14T18:06:10Z

Any update on this? Really looking forward to this :)

kurko · 2015-04-19T19:51:59Z

So, does any one have any problems with this? If not, I'm merging this pretty soon (likely tomorrow).

guilleiguaran · 2015-04-19T22:37:45Z

@kurko can you paste the code you used for benchmarks in a gist?

kurko · 2015-04-21T20:56:08Z

# both fragment
cache only: [:field1, :field2, :etc]

# and not fragment
cache

# then, in an integration test:
Benchmark.bm do |x|
  x.report do
    1000.times do
      get "/users/#{user.id}", nil
    end
  end
end

Adding Fragment Cache to AMS

joaomdmoura · 2015-04-21T21:00:29Z

\o/ :laughing:

mib32 · 2015-08-18T14:53:46Z

lib/active_model/serializer/adapter/fragment_cache.rb

+        end
+
+        def fragment_serializer(name, klass)
+          cached     = "#{name.capitalize}CachedSerializer"


If different serializers share the same model, but has totally different attributes, would their caches collide, even if the key is different? I believe i see it on my machine. If you believe this could happen, i can present those tests to you, but i need time to set it up.

maybe it should go something like cached = "#{serializer.name}CachedSerializer"?

Yeap, I think it could happen. Not the cache_key itself, because it takes the file path into account but the Class name would colide.
I'll check it on the master codebase, create a new issue for that and update it.

@joaomdmoura thanks, that would be great!
Here is the stack trace of the error i've got, when the classes collide, in case you would like to look at it. The latter called serializer tries to look for an attribute that was held by the first serializer, but not in the latter. Am i abusing the way serializers should be used, if i'm the first one who's got that error?

Failure/Error: get '/markers/local.json?coordinates=55.75,36.00&limit=10' NoMethodError: undefined method `name' for #<MarkerDistanceSerializer:0x007f80339b6eb8> # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer.rb:155:in `public_send' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer.rb:155:in `block in attributes' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer.rb:151:in `each' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer.rb:151:in `each_with_object' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer.rb:151:in `attributes' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/json.rb:15:in `block in serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter.rb:51:in `block in cache_check' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/cache.rb:299:in `block in fetch' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/cache.rb:585:in `block in save_block_result_to_cache' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/cache.rb:547:in `block in instrument' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/notifications.rb:166:in `instrument' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/cache.rb:547:in `instrument' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/cache.rb:584:in `save_block_result_to_cache' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/cache.rb:299:in `fetch' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter.rb:50:in `cache_check' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/json.rb:14:in `serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/flatten_json.rb:6:in `serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/fragment_cache.rb:27:in `fetch' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter.rb:54:in `cache_check' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/json.rb:14:in `serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/flatten_json.rb:6:in `serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/json.rb:10:in `block in serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/array_serializer.rb:6:in `each' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/array_serializer.rb:6:in `each' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/json.rb:10:in `map' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/json.rb:10:in `serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter/flatten_json.rb:6:in `serializable_hash' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/active_model/serializer/adapter.rb:24:in `as_json' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/json/encoding.rb:35:in `encode' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/json/encoding.rb:22:in `encode' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/object/json.rb:37:in `to_json_with_active_support_encoder' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/renderers.rb:116:in `block in <module:Renderers>' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/bundler/gems/active_model_serializers-e7d3323d2352/lib/action_controller/serialization.rb:51:in `block (2 levels) in <module:Serialization>' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/renderers.rb:45:in `block in _render_to_body_with_renderer' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/renderers.rb:41:in `_render_to_body_with_renderer' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/renderers.rb:37:in `render_to_body' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/abstract_controller/rendering.rb:25:in `render' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/rendering.rb:16:in `render' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/benchmark.rb:12:in `block in ms' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activesupport-4.2.3/lib/active_support/core_ext/benchmark.rb:12:in `ms' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/instrumentation.rb:44:in `block in render' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/activerecord-4.2.3/lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/instrumentation.rb:43:in `render' # /Users/antonmurygin/.rvm/gems/ruby-2.2.2/gems/remotipart-1.2.1/lib/remotipart/render_overrides.rb:14:in `render_with_remotipart' # ./app/controllers/markers_controller.rb:20:in `block (2 levels) in local'

ref: - rails-api#827 - rails-api#832 - rails-api#872 - rails-api#1045 - rails-api#912 - rails-api#911 - rails-api#904 - rails-api#810 - rails-api#693 - rails-api#849 - rails-api#1029 - rails-api#1300 - rails-api#1372

bf4 · 2015-12-16T10:44:09Z

@kurko I'm trying to write a benchmark with positive results for caching but haven't been able to show differences with it on or off. I'm probably missing something. I see you had a working benchmark at one point. help?

#810 (comment)

Update: here are the numbers I got:

               user        system    total     real
no cache       21.550000   1.820000  23.370000 ( 28.894494)
cache          16.870000   1.580000  18.450000 ( 21.429540)
fragment cache 22.270000   1.810000  24.080000 ( 28.504920)

(cache means `only: []` wasn't used in the serializer)

#810 (comment)

# both fragment
cache only: [:field1, :field2, :etc]

# and not fragment
cache

# then, in an integration test:
Benchmark.bm do |x|
  x.report do
    1000.times do
      get "/users/#{user.id}", nil
    end
  end
end

beauby · 2015-12-30T15:28:17Z

@bf4 Any change when changing this line from

end unless method_defined?(key) || _fragmented.respond_to?(attr)

to

end unless method_defined?(key) || _fragmented.respond_to?(key)

?

bf4 · 2015-12-30T15:46:19Z

@beauby The number in the comment #810 (comment) were a quote of @kurko . I haven't been able to replicate much.. see #1393

kurko reviewed Feb 12, 2015
View reviewed changes

joaomdmoura force-pushed the fragment-cache branch 2 times, most recently from 7df73c0 to 3de7324 Compare February 12, 2015 22:17

kurko reviewed Feb 13, 2015
View reviewed changes

joaomdmoura force-pushed the fragment-cache branch 4 times, most recently from a96cbe7 to 966c233 Compare February 21, 2015 00:46

kurko reviewed Feb 23, 2015
View reviewed changes

kurko added the V: 0.10.x label Mar 1, 2015

joaomdmoura force-pushed the fragment-cache branch from 966c233 to ed32db4 Compare March 2, 2015 23:30

joaomdmoura reviewed Mar 2, 2015
View reviewed changes

joaomdmoura force-pushed the fragment-cache branch from 163aa1d to f7fc56f Compare March 24, 2015 18:53

joaomdmoura force-pushed the fragment-cache branch 2 times, most recently from 2f7490c to b8c5af4 Compare March 27, 2015 07:22

kurko reviewed Apr 2, 2015
View reviewed changes

joaomdmoura force-pushed the fragment-cache branch from b8c5af4 to a2023b9 Compare April 2, 2015 18:50

Adding Fragment Cache to AMS

792fb8a

It's an upgrade based on the new Cache implementation rails-api#693. It allows to use the Rails conventions to cache specific attributes or associations. It's based on the Cache Composition implementation.

joaomdmoura force-pushed the fragment-cache branch from a2023b9 to 792fb8a Compare April 5, 2015 21:20

kurko added a commit that referenced this pull request Apr 21, 2015

Merge pull request #810 from joaomdmoura/fragment-cache

168c36f

Adding Fragment Cache to AMS

kurko merged commit 168c36f into rails-api:master Apr 21, 2015

yuki24 mentioned this pull request May 28, 2015

Rails api rails/rails#19832

Merged

mib32 reviewed Aug 18, 2015
View reviewed changes

bf4 mentioned this pull request Nov 19, 2015

Get tests passing on Rails 5 #1324

Merged

Adding Fragment Cache to AMS #810

Adding Fragment Cache to AMS #810

Conversation

joaomdmoura commented Feb 12, 2015

joaomdmoura commented Feb 12, 2015

Choose a reason for hiding this comment

guilleiguaran commented Feb 12, 2015

joaomdmoura commented Feb 12, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshsmith commented Feb 16, 2015

thibaudgg commented Feb 18, 2015

joaomdmoura commented Feb 18, 2015

thibaudgg commented Feb 19, 2015

joaomdmoura commented Feb 21, 2015

joshsmith commented Feb 21, 2015

kurko commented Feb 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thibaudgg commented Mar 23, 2015

brancusi commented Mar 23, 2015

kurko commented Mar 24, 2015

kurko commented Mar 26, 2015

joaomdmoura commented Mar 27, 2015

kurko commented Apr 1, 2015

Choose a reason for hiding this comment

kurko commented Apr 5, 2015

joaomdmoura commented Apr 6, 2015

kurko commented Apr 6, 2015

Catalectic commented Apr 14, 2015

kurko commented Apr 19, 2015

guilleiguaran commented Apr 19, 2015

kurko commented Apr 21, 2015

joaomdmoura commented Apr 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bf4 commented Dec 16, 2015

beauby commented Dec 30, 2015

bf4 commented Dec 30, 2015