remove dynamic class creation where not needed #1850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part n+1 in a long-running series of test improvements. This particular episode is to discourage people from (or at least not show them how to) dynamically creating classes for testing when they don't need to be dynamically created.
Changes
any class-level
SubClass = Class.new(SuperClass)
was converted toclass SubClass < SuperClass; end
Caveats
None
Related GitHub issues
#1848 (comment)
Additional helpful information
Step next will be renaming tests from
def test_method_whatever
totest 'this is what is being tested' do