[WIP] Test Updates: Part 2 of 3

[NullVoxPopuli]

Purpose

Using morre proper test naming

Changes

find def test_(.+)$
replace with test '$1' do

also, replace

def my_method

ensure

end

with

test 'my_method'
  begin
  ensure
  end
end

Caveats

ensure can no longer be used by itself, as test blocks aren't methods

Related GitHub issues

#1850

Additional helpful information

Hopefully this will encourage future contributions to use the same test style

[NullVoxPopuli]

current issue: test is being interpreted weird, and it thinks the string is a command

[NullVoxPopuli]

Interesting: I can't find much mention of the test 'what am I testing' syntax, but there is a lot of talk of minitset supporting expectation style test naming... hmm

[NullVoxPopuli]

I may put this on hold, and skip to step 3 (which is just re-organizing the test files)

[bf4]

this syntax comes from ActiveSupport::TestCase

[NullVoxPopuli]

thanks!

[bf4]

This is in the gemspec. Was something not working?

[bf4]

Looks fine to me once tests pass. Maybe leave all the ones with ensure alone for now?

[NullVoxPopuli]

I'm going to re-do this PR with your suggestions after #1863 is merged (hopefully). It's mostly a regex replace on the test names. And now that I know about ActiveSupport::Test, everything should pass next attempt