Remove --skip-yarn in favor of --skip-javascript
#34275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kamipo (@rails-bot has picked a reviewer for you, use r? to override) |
bogdanvlviv
commented
Oct 22, 2018
| @@ -5,7 +5,7 @@ Rails.application.config.assets.version = '1.0' | |||
|
|
|||
| # Add additional assets to the asset load path. | |||
| # Rails.application.config.assets.paths << Emoji.images_path | |||
| <%- unless options[:skip_yarn] -%> | |||
| <%- unless options[:skip_javascript] -%> | |||
| # Add Yarn node_modules folder to the asset load path. | |||
| Rails.application.config.assets.paths << Rails.root.join('node_modules') | |||
There was a problem hiding this comment.
I think we can remove this since we use webpack for js(#33079)?
| @@ -5,7 +5,7 @@ Rails.application.config.assets.version = '1.0' | |||
|
|
|||
| # Add additional assets to the asset load path. | |||
| # Rails.application.config.assets.paths << Emoji.images_path | |||
| <%- unless options[:skip_yarn] -%> | |||
| <%- unless options[:skip_javascript] -%> | |||
| # Add Yarn node_modules folder to the asset load path. | |||
| Rails.application.config.assets.paths << Rails.root.join('node_modules') | |||
There was a problem hiding this comment.
I think we can remove this since we use webpack for js(#33079)?
Since rails#33079 Webpacker the default JavaScript compiler for Rails. Webpacker uses `yarn` so seems like it doesn't make sense for Rails to keep `--skip-yarn` option.
bogdanvlviv
force-pushed
the
skip_yarn-to-skip_javascript
branch
from
54aeee4 to
2bf9887
Compare
…by default Related to rails#33079
bogdanvlviv
force-pushed
the
skip_yarn-to-skip_javascript
branch
from
2bf9887 to
129f8ac
Compare
3 tasks
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Sep 4, 2019
With rails/rails#34275 rails new option named skip_yarn is changed into skip_javascript. This option allows us to still use sprockets for JS in our sandbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #33079 Webpacker the default JavaScript compiler for Rails.
Webpacker uses
yarnso seems like it doesn't make sense for Rails to keep--skip-yarnoption.