Avoid installing webpacker in sandbox #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
changed the title
kennyadsl
changed the title
With rails/rails#34275 rails new option named skip_yarn is changed into skip_javascript. This option allows us to still use sprockets for JS in our sandbox.
kennyadsl
force-pushed
the
kennyadsl/no-webpacker-sandbox
branch
from
8e4b8c9 to
5f253b4
Compare
jacobherrington
approved these changes
Sep 4, 2019
tvdeyen
approved these changes
Sep 4, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With rails/rails#34275
rails newoption named--skip_yarnis changed into--skip_javascript. This PR reflects this change and keeps allowing us to still use sprockets for JS in our sandbox.TODO
Using this option with Rails 6, sandbox does not contain anyMy fault, that folder is not needed in the sandbox since the sandbox application will use the manifests defined in the solidus gems.app/assets/javascriptsfolder, so I think Solidus manifests is not loaded correctly. This needs to be investigated.Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)