Skip adding webpacker gem when generating dummyapp #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Feb 5, 2021
| @@ -44,6 +44,7 @@ def generate_test_dummy | |||
| opts[:skip_yarn] = true | |||
| opts[:skip_bootsnap] = true | |||
| opts[:skip_webpack_install] = true | |||
| opts[:skip_javascript] = true | |||
There was a problem hiding this comment.
Is skip_webpack_install needed if we have skip_javascript?
There was a problem hiding this comment.
Actually not! 👍
Pushing the skip_webpack_install removal.
There was a problem hiding this comment.
Rails reference for webpack installation https://github.com/rails/rails/blob/6-1-stable/railties/lib/rails/generators/app_base.rb#L408
`skip-webpack-install` prevents rails to run the webpacker install task but the webpacker helper (javascript_pack_tag) is still included in `layouts/application.html.erb` as webpacker is the Rails 6 default. `--skip-javascript` avoids webpacker to be included in the rails generated app.[1] [1]: rails/rails#35484 (comment)
SamuelMartini
force-pushed
the
SamuelMartini/no_webpacker_dummy_generator
branch
from
a06a461 to
b97c136
Compare
spaghetticode
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the dummy app generated to test extensions has the
javascript_pack_taghelper included inlayouts/application.html.erb. This is becauseskip-webpack-installonly prevents rails to run the webpacker install task but being webpacker the default for Rails 6, it is still included in the generated view.--skip-javascriptavoids webpacker to be included in the rails generated app.1Related pr #3326 where
--skip-javascriptis used in the sandbox generation.Checklist: