Drop rubocop-minitest from gem dependency #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rails#13. This PR drops rubocop-minitest from gem dependency. In fact, the `Minitest` department's Cop is not used in rubocop-rails-omakase: https://github.com/rails/rubocop-rails-omakase/blob/v1.0.0/rubocop.yml This means that it might be appropriate for users to add the `Minitest` department's cop only when they start using it. As a result, there will be no need to install gems that are not included in the rubocop-rails-omakase configuration. Users can be given the choice to add cops based on the testing framework they are using.
Member
|
Let's introduce a small set of Minitest cops (like Minitest/AssertNil) rather than removing. |
Contributor
Author
|
RuboCop Minitest includes a considerable number of cops. Therefore, it will likely be necessary to establish clear criteria when selecting a smaller subset. For example, it might be considered to enable Minitest cops that align with the "Assertions" section of the Minitest Style Guide, but even then, it might still feel like a large number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13.
This PR drops rubocop-minitest from gem dependency.
In fact, the
Minitestdepartment's Cop is not used in rubocop-rails-omakase: https://github.com/rails/rubocop-rails-omakase/blob/v1.0.0/rubocop.ymlThis means that it might be appropriate for users to add the
Minitestdepartment's cop only when they start using it. As a result, there will be no need to install gems that are not included in the rubocop-rails-omakase configuration.Users can be given the choice to add cops based on the testing framework they are using.