Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to ensure our "virtual" glob sass file has a unique name otherwise it gets
.uniq'd alway in Sass's dependencySethere https://github.com/sass/sass/blob/2bdc564dea068c4e19064daea25349d93f8d01b8/lib/sass/engine.rb#L331It sorta makes me worry a little bit about the virtual file approach.
:filename => nilwould make more sense in this case, but other internal sass APIs seem to assume:filenameexists for any relative import calls. So those would crash or be incorrect if we set it tonilor some random value. Another approach might be writing out a "real" file to tmp, but I don't know how that would affect sass's internal cache.Fixes #299.
/cc
@ksylvest if you wouldn't mind testing this branch before we do a final release
@rafaelfranca we'll probably want to cut a new patch level release after this.