Skip to content

Fix glob caching bug #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josh merged 2 commits into from
Dec 24, 2014
Merged

Fix glob caching bug #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57bb882
Ensure virtual glob file has a unique filename
josh Dec 20, 2014
86f5ed9
Merge branch 'master' into fix-glob-virtual-file
josh Dec 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/sass/rails/importer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def glob_imports(base, glob, options)
end
return nil if contents == ""
Sass::Engine.new(contents, options.merge(
:filename => base,
:importer => self,
:syntax => :scss
))
Expand Down
17 changes: 17 additions & 0 deletions test/sass_rails_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,23 @@ class SassRailsTest < Sass::Rails::TestCase
end
end

test 'globbed imports work when globbed file is changed' do
project = 'scss_project'
filename = 'application.scss'

within_rails_app(project) do |tmpdir|
asset_output(filename)

new_file = File.join(tmpdir, 'app', 'assets', 'stylesheets', 'globbed', 'globbed.scss')
File.open(new_file, 'w') do |file|
file.puts '.changed-file-test { color: #000; }'
end

css_output = asset_output(filename)
assert_match /changed-file-test/, css_output
end
end

test 'sass asset paths work' do
css_output = sprockets_render('scss_project', 'application.scss')
assert_match %r{asset-path:\s*"/assets/rails.png"}, css_output, 'asset-path:\s*"/assets/rails.png"'
Expand Down