Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake webpacker:check_node does handle extended Node.JS versions #1598

Closed
jbotelho2-bb opened this issue Jul 5, 2018 · 1 comment
Closed

Comments

@jbotelho2-bb
Copy link

It looks like the webpacker:check_node uses the Gem::Version parser to parse Node.JS versions:

version = Gem::Version.new(node_version.strip.tr("v", ""))

Unfortunately, this is only able to parse a subset of possible Node.JS versions. We have started tagging our Node.JS builds with extended version numbers (e.g. 8.11.2+some-tag), which is valid according to the semver convention that Node.JS follows, but results in webpacker blowing up:

rake aborted!
       ArgumentError: Malformed version number string 8.11.3+0-b20180704T02124290
       /opt/lib64/ruby/2.4.0/rubygems/version.rb:208:in `initialize'
       /opt/lib64/ruby/2.4.0/rubygems/version.rb:199:in `new'
       /opt/lib64/ruby/2.4.0/rubygems/version.rb:199:in `new'
       /tmp/build/vendor/bundle/ruby/2.4.0/gems/webpacker-3.5.3/lib/tasks/webpacker/check_node.rake:12:in `block (2 levels) in <top (required)>'
@gauravtiwari
Copy link
Member

Feel free to make a PR please :)

KingTiger001 added a commit to KingTiger001/Rails-web-pack-project that referenced this issue Jan 15, 2023
smartech7 pushed a commit to smartech7/ruby-webpacker that referenced this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants