Add better conditional messaging for checking yarn & node #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a valid semver engine version could be an illformed gem requirement, which raising an exception during the parsing of this value from the package.json in either of these tasks.
Add test for check_node, check_yarn tasks
jakeNiemiec
force-pushed
the
better-rake-checks
branch
from
9bf99e0 to
5e6c730
Compare
….JS versions closes #1598
jakeNiemiec
changed the title
jakeNiemiec
referenced
this pull request
Feb 12, 2020
#2454) * Allow node.js 8.9 engine compatibility 8.16 is somewhat arbitrary as far as I can tell, so this allows earlier 8.x releases of node.js as the engine so that 8.9, 8.10, 8.12, etc from Ubuntu 18.04 LTS can install this package. #2228 * restrict to compatible yarn engine versions Co-Authored-By: Jake Niemiec <jake.j.niemiec@gmail.com> * restrict to compatible node engine versions As 13 has been released, an upper limit is prudent as well. Co-Authored-By: Jake Niemiec <jake.j.niemiec@gmail.com> Co-authored-by: Jake Niemiec <jake.j.niemiec@gmail.com>
jakeNiemiec
referenced
this pull request
Feb 12, 2020
Yarn enforces strict engine testing yarnpkg/rfcs#69 (comment) so this manifests as an error rather than a warning.
|
Hope this helps! Sorry for the headache 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly serves to better warn users about using unstable or unsupported versions of yarn & node. (see fixes below for examples)
changes
package.json["engines"]are now handled by the semantic_range gem, a rewrite of the one that node.js is bundled with$stderr.puts "Exiting!" && exit!is fixed so that "Exiting!" is actually displayedfixes
related