Clear error message when yarn or node not installed #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when yarn is NOT installed I run into the following issue: $ rake webpacker:check_yarn bin/rails: No such file or directory - yarn rails aborted! NoMethodError: undefined method `strip' for nil:NilClass Tasks: TOP => webpacker:check_yarn (See full trace by running task with --trace) It looks like lib/tasks/webpacker/check_yarn.rake behaves as expected when line 6 calls yarn_version = `yarn --version`.strip. When yarn is not installed the shell raises an exception and is rescued on line 25. HOWEVER! When running this in the application, Rails will rescue this exception and `yarn --version` will return nil. The tests do not test this adequately in a Rails environment. This fix will more elegantly call `which yarn` first and follow the expected error handling.
melissavoegeli
changed the title
|
Hi @melissavoegeli ! 👋 Thank you for your contribution! Great fix 🍻 Looks good to be merged ✅ @gauravtiwari |
guilleiguaran
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses #954
When yarn is NOT installed I run into the following issue:
It looks like lib/tasks/webpacker/check_yarn.rake behaves as expected when line 6 calls
yarn_version = `yarn --version`.strip. When yarn is not installed the shell raises an exception and is rescued on line 25.HOWEVER! When running this in the application, Rails will rescue this exception and
yarn --versionwill return nil. The tests do not test this adequately in a Rails environment.This fix will more elegantly call
which yarnfirst and follow the expected error handling.