Remove node/yarn dependency from clobber and support windows #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a twofer, because I ran into one issue while trying to fix the other.
The first issue fixed was introduced in #2943, which uses a platform specific shell command to determine if yarn/node are installed. This PR updates this change to use an equivelant windows command on windows platforms.
The second change removes the dependency on yarn and node when running webpacker:clobber, since neither of these are needed. This is fairly important because webpacker:clobber is implicitly called when assets:clobber is called, which you might call on a server that's not set up for development (and therefor missing node/yarn).