Always use content hash for MiniCssExtractPlugin #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Javascript packs in development mode, files are outputted with hashes in the file names so browser cache is automatically busted when code is changed and new files are made. However, the mini-css-extract-plugin plugin is only configured to output files with hashes in production mode. This means that any changes to CSS files locally will appear to not have any effect on the page you are working on because the browser is assuming the resulting CSS file with the same name has not changed and reloads the cached version, forcing us to manually bust browser cache to see our changes. This code change enables the hash-based file names for the plugin regardless of environment.
|
Hit this several times already, would be nice to have this consistent. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2928
With Javascript packs in development mode, files are outputted with
hashes in the file names so browser cache is automatically busted when
code is changed and new files are made.
However, the mini-css-extract-plugin plugin is only configured to output
files with hashes in production mode. This means that any changes to CSS
files locally will appear to not have any effect on the page you are
working on because the browser is assuming the resulting CSS file with
the same name has not changed and reloads the cached version, forcing us
to manually bust browser cache to see our changes.
This code change enables the hash-based file names for the plugin
regardless of environment.