Skip contenthash when not production #3060
Conversation
|
Hey @justin808, this PR looks like it reverts the changes made in #2954, which implemented a fix for stylesheets not being reloaded in certain browsers in development. Would the issue described in that PR return if these changes were merged? Code-wise it seems to revert settings for the MiniCssExtractPlugin to what they were before #2954 was merged if I see correctly? |
package/environments/base.js
Outdated
| }) | ||
| ) | ||
| } | ||
|
|
||
| return plugins | ||
| } | ||
|
|
||
| // Don't use contentHash except for production for performance | ||
| // https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling | ||
| const filenameHash = isProduction ? '-[contenthash]' : ''; |
There was a problem hiding this comment.
| const filenameHash = isProduction ? '-[contenthash]' : ''; | |
| const hash = isProduction ? '-[contenthash]' : ''; |
For consistency
There was a problem hiding this comment.
We are not using semicolons at all. So should strip instead.
CSS gets the |
Per the webpack docs on better performance, the contenthash should be skipped when not on production. https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling
justin808
force-pushed
the
justin808/skip-conenthash-when-not-production
branch
from
e2309f0 to
24a01d8
Compare
|
@guillaumebriday Comments addressed. Tomorrow, HST, I'll try to update https://github.com/shakacode/react_on_rails_tutorial_with_ssr_and_hmr_fast_refresh with this change to test this out. |
justin808
force-pushed
the
justin808/skip-conenthash-when-not-production
branch
from
24a01d8 to
96062a7
Compare
|
I'm slightly perplexed as to what the end result is going to be now. For those of use using webpacker for straight up JS and CSS use (no react), does this plus HMR allow in dev mode to let us change JS and CSS and have those changes be shown in the browser? If the filenames rename the same, browsers will treat it as a cached file and not attempt to pull in the new code. That would force developers to run their browsers with caching disabled via the network tab in the inspector. That was the whole point of adding the hashes in #2954 for CSS as the JS code was being refreshed on save but not the CSS. |
|
A more specific example: I have apps thare are simply turbo, stimulus, and tailwind all going through the current webpacker beta. No react. No SSR. Just straight up bundled JS and CSS. I start up |
|
I'm pretty sure that the Rails server lets the browser know to not cache the files during development. |
|
Appolgies if I came off strong earlier. I managed (barely) to get master hooked up to an app and did confirm that these changes (plus #3031) does appear to properly refresh any changed CSS and JS (at least with some limited local testing). The whole webpack/JS ecosystem is still a bit of a black box to me, but somehow this is pushing changes without having to have file names with different hashes in them. 🤷 |
Per the webpack docs on better performance, the contenthash should be
skipped when not on production.
https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling