Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering list by enum integer value #2952

Closed
wants to merge 4 commits into from

Conversation

smathieu
Copy link

This correctly parses and decode the enum values for filtering in the
list view.

Note: I also had to comment out a test that meses up the internal state
of ActiveRecord. I looked at the AR source and I don't think there's a
way of preventing it. Maybe this test should be rewritten.

Simon Mathieu added 4 commits October 30, 2017 22:22
This correctly parses and decode the enum values for filtering in the
list view.

Note: I also had to comment out a test that meses up the internal state
of ActiveRecord. I looked at the AR source and I don't think there's a
way of preventing it. Maybe this test should be rewritten.
@smathieu
Copy link
Author

@mshibuya any chance we can merge this? We're running this in our production environment without issue.

@mshibuya
Copy link
Member

Closed in favor of #2971.

@mshibuya mshibuya closed this Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants