Fixed filter by enum filter when label <> value #2971
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you add a test case for that issue? |
Contributor
Author
|
Sure, I will add tests. |
Refactored code to remove unnecessary calls to `parse_value`.
Which were affecting filter by enum (rails >= 5.0):
If enum defined like
```
enum size: { L: 'l', S: 's' }
```
Due to multiple calls, the chain when filtering by size is following:
```
parse_value("l") => "L"
parse_value("L") => null
```
Which leads to non working filtering.
NOTE: `parse_value` returns correct result in both cases above
Contributor
Author
|
work in progress. |
Contributor
Author
|
Turns out that fix provided in #2952 for |
Rails does not support yet pg v1.0.0 more details here: rails/rails#31669
Contributor
Author
|
@mshibuya I have added tests. And have rebased them, so it is possible to see in travis logs that without fix they are failing. |
mshibuya
added a commit
that referenced
this pull request
Feb 17, 2018
Fixed filter by enum filter when label <> value
Member
|
Merged in 8576961, thanks so much! |
Contributor
Author
|
👍 thank you. |
Closed
mshibuya
added a commit
that referenced
this pull request
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored code to remove unnecessary calls to
parse_value.Which were affecting filter by enum (rails >= 5.0):
If enum defined like
Due to multiple calls, the chain when filtering by size is following:
Which leads to non working filtering.
NOTE:
parse_valuereturns correct result in both cases above