Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filter by enum filter when label <> value #2971

Closed
wants to merge 6 commits into from
Closed

Fixed filter by enum filter when label <> value #2971

wants to merge 6 commits into from

Commits on Dec 30, 2017

  1. Configuration menu
    Copy the full SHA
    5422bd0 View commit details
    Browse the repository at this point in the history
  2. Fixed filter by enum filter when label <> value

    Refactored code to remove unnecessary calls to `parse_value`.
    Which were affecting filter by enum (rails >= 5.0):
    If enum defined like
    ```
    enum size: { L: 'l', S: 's' }
    ```
    Due to multiple calls, the chain when filtering by size is following:
    ```
    parse_value("l") => "L"
    parse_value("L") => null
    ```
    Which leads to non working filtering.
    NOTE: `parse_value` returns correct result in both cases above
    mshytikov committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    d89eb9e View commit details
    Browse the repository at this point in the history
  3. [rubocop]

    mshytikov committed Dec 30, 2017
    Configuration menu
    Copy the full SHA
    f252603 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. Applied fix from PR #2952

    mshytikov committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    9f888b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Configuration menu
    Copy the full SHA
    1720e49 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. Fix pg versions to ~> 0.21.

    Rails does not support yet pg v1.0.0
    more details here: rails/rails#31669
    mshytikov committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    b5ccb78 View commit details
    Browse the repository at this point in the history