This repository has been archived by the owner on May 21, 2019. It is now read-only.
Changed the macOS ⌘ symbol to 'Ctrl+' on non-darwin platforms. #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
ForNeVeR
reviewed
Jul 28, 2017
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.0.1.tgz", | ||
| "integrity": "sha512-Mp+FXEI+FrwY/XYV45b2YD3E8i3HwnEAoFcM0qlZzq/RZ9RwWitt2Y/c7cqRAz70U7hfekqx6qNYthuKFO6K0g==", | ||
| "dev": true, | ||
| "req |
There was a problem hiding this comment.
I don't think you should introduce package-lock.json in an unrelevant PR. That should be the decision properly discussed with maintainer (probably in a new issue).
There was a problem hiding this comment.
Heck. I accidentally used the -a upon commit. I didn't notice. Lemme fix it.
|
Closing this PR in favor of #1141. |
|
@christianwico just a small friendly GitHub tip: you don't need to create a new PR if you want to replace the contents of a previous one. You could modify your commit with |
|
@ForNeVeR eheh. My apologies. I'm new to this GitHub culture. I'll remember next time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisions to the Tab Component to change the ⌘ into Ctrl+ if the platform is not darwin (macOS/Mac OS X).
(I'd recommend for someone with a Mac to first test if ⌘ instead appears if upterm is ran on a Mac. I "peasant-tested" this by switching the if shorthand (TabComponent.tsx, line 48) between win32 and darwin. It seems to be working.