This repository has been archived by the owner on May 21, 2019. It is now read-only.
Changed the macOS ⌘ symbol to 'Ctrl+' on non-darwin platforms. #1141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisions to the Tab Component to change the ⌘ into Ctrl+ if the platform is not darwin (macOS/Mac OS X).
(I'd recommend for someone with a Mac to first test if ⌘ instead appears if upterm is ran on a Mac. I "peasant-tested" this by switching the if shorthand (TabComponent.tsx, line 48) between
win32
anddarwin
. It seems to be working.)QUICK CHANGES:
package-lock.json
file. (Closing Changed the macOS ⌘ symbol to 'Ctrl+' on non-darwin platforms. #1140 in favor of this.)