Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Changed the macOS ⌘ symbol to 'Ctrl+' on non-darwin platforms. #1141

Closed
wants to merge 1 commit into from

Conversation

christianwico
Copy link
Contributor

@christianwico christianwico commented Jul 28, 2017

Revisions to the Tab Component to change the ⌘ into Ctrl+ if the platform is not darwin (macOS/Mac OS X).

(I'd recommend for someone with a Mac to first test if ⌘ instead appears if upterm is ran on a Mac. I "peasant-tested" this by switching the if shorthand (TabComponent.tsx, line 48) between win32 and darwin. It seems to be working.)

QUICK CHANGES:

@vlad-shatskyi
Copy link
Contributor

vlad-shatskyi commented Jul 28, 2017

Thanks for your contribution. I'm afraid you chose not the best time to add it. I just changed this part of code yesterday and now you have conflicts. The component is now called TabHeaderComponent and looks a bit differently. Please

  • Resolve conflicts.
  • Use import instead of require.
  • Don't use inline CSS. I'm trying to move away from it.
  • Make sure it still looks alright with the new styles from master.

@vlad-shatskyi
Copy link
Contributor

Hey, @christianwico. It's been awhile since this PR was opened. Do you plan updating it, or should I close it?

@eko24ive
Copy link

@vlad-shatskyi Hello, is this PR required? If so - I'd like to collaborate on it regarding issues you've described?

@vlad-shatskyi
Copy link
Contributor

Hey, @eko24ive. I don't think it's required. We're going to re-do tabs anyway: people want to see more information in a tab name.

@eko24ive
Copy link

Alright, thank you for reply then :3 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants