Fix #1241: nixpack plan generates an invalid toml file ... #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…python projects containing a .tool-versions file. I assume that outputting those lines before the toml or json file is not intended. If it is then please ignore this commit. Another option might be to print these messages to stderr instead?
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
This pull request was closed for lack of activity. Feel free to reopen later. |
coffee-cup
approved these changes
Jan 6, 2025
coffee-cup
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1241 nixpack plan generates an invalid toml file for python projects containing a .tool-versions file.
I assume that outputting those lines before the toml or json file is not intended. If it is then please ignore this commit.
Another option might be to print these messages to stderr instead?