fix(plan): stdout logic for valid output files #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't let build plans generate anything other than the build plan itself. If an error or warning should be generated, it should be outputted to stderr. That way consumers can be pretty confident that the output is only ever in valid TOML/JSON format.
CoderJoshDK
changed the title
coffee-cup
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let build plans generate anything invalid files. If an error or warning should be generated, it should be outputted to stderr. That way, consumers can be pretty confident that the output is only ever in valid TOML/JSON format.
This closes #1241 and is a slightly more complete solution over #1242.
Considerations were made to have a "verbose mode" however, doing that would require significant refactoring, all for only 3 or 4 impacted providers. Instead, recoverable errors should be directed to stderr using
eprintln!