Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tappable area on wallet name #5496

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix tappable area on wallet name #5496

merged 1 commit into from
Mar 13, 2024

Conversation

BrodyHughes
Copy link
Member

Fixes APP-1086

What changed (plus any additional context for devs)

  • z-index

What to test

  • tap wallet name + settings menu + qr code scanner make sure they work as intended.

@linear Linear
Copy link

linear bot commented Mar 12, 2024

APP-1086 Can't open QR scanner with really long wallet name

@BrodyHughes
Copy link
Member Author

I have a screen recording showing it works but my wifi is being so dumb rn. will try to upload in a bit.

@skylarbarrera skylarbarrera merged commit f35c6df into develop Mar 13, 2024
5 of 6 checks passed
@skylarbarrera skylarbarrera deleted the brody/fix-long-name-safe-area branch March 13, 2024 15:21
@benisgold benisgold mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@dereknelson dereknelson Awaiting requested review from dereknelson

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrodyHughes @walmat @skylarbarrera