Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix WalletScreen navbar onPress while scrolled #6309

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

benisgold
Copy link
Member

Fixes APP-2134

What changed (plus any additional context for devs)

Problem

A change in PR #5496 made the wallet name button in the WalletScreen navbar non-interactive. While attempting to ensure the QR and settings buttons remained pressable by adding a negative zIndex to the wallet name component, the wallet name button was inadvertently placed behind the navbar, making it inaccessible.

Solution

  • Removed the negative zIndex from the wallet name component
  • Adjusted its incorrectly calculated maxWidth constraint to prevent the wallet name from overlapping with QR and settings buttons

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-07.at.16.58.31.mp4

What to test

  • long wallet names are properly displayed/truncated
  • long wallet names do not interfere with other navbar buttons
  • pressing wallet name on navbar opens the ChangeWalletSheet regardless of whether screen is scrolled

@benisgold benisgold requested review from walmat and maxbbb December 7, 2024 22:17
Copy link

linear bot commented Dec 7, 2024

@brunobar79
Copy link
Member

Launch in simulator or device for e37e1ed

Copy link
Contributor

@maxbbb maxbbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. e2e fail looks unrelated.

@benisgold benisgold merged commit 7dc1b03 into develop Dec 9, 2024
8 checks passed
@benisgold benisgold deleted the @benisgold/navbar-fix branch December 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants