Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the update request form in the request detail page, so that updates can be made there, and hence removed the update request buttons from the main request table. #901

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

shashwat1002
Copy link

Issue Reference

This PR addresses the Issue : Fixes #880

Summarize

Any update to any request can now be made from the details page of that request, hence the update button is no longer necessary, and hence removed the update column from the main requests table, making that page less cluttered, changed the name of the more details column to "More Details/ update the request" in English and in Malayalam- changed the name of the More detail buttons to More details / update

Also, mention the key points if any to look into while code reviews

.gitignore Outdated
@@ -5,6 +5,8 @@ __pycache__
.env
staticfiles/
mysite.log
settings.py
Copy link

@biswaz biswaz Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this.
(Thank GOD I'm not Linus Torvalds 😄 )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad :33, I did it for my convenience, forgot to change back.
Just fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants