Release v1.1.0 #1296
Merged
Release v1.1.0 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/digitalbazaar/forge/releases) - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: node-forge dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- think I mostly have everything working but no tests
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- also split downloadApi into api functions and rq hooks - this makes it easier to test and also smaller files - also add test for disabling download of carts with empty items
- also fixed bug in e2e server code serving the wrong settings file
- also memoise loadMoreRows
- remove batched updates and increase the concurrency
Depending on if a filterByTime prop is passed, the date filter component will return either a KeyboardDatePicker or a KeyboardDateTimePicker. Thus, the admin download table now contains a KeyboardDateTimePicker for more accurate filtering of results
Now completely removing the ability to set the seconds value in the admin download table date filtering. Previously, this was possible and causing issues with expected results. To align with the date picker GUI, we can now only go down to the minute level. Also removing changes made to index.tsx. This was to mistakenly account for time inputs to be filtered but this is not needed in index as it can only receive a set date value. As such, the start date will carry on with a time of 00:00:00 and the end date will carry on with a time of 23:59:59 inclusive
Increases number of lines so worth deciding if this is beneficial or not
…ate column filter #1175 To align with Topcat, the date pickers in the download table need to be date time pickers Fixing bug in aria hidden prop passing to date picker objects
Incorrectly "fixed" the test, there is still something going wrong here
…common props - also extract more common props
…node-forge-1.3.0 Bump node-forge from 1.2.1 to 1.3.0
…minimist-1.2.6 Bump minimist from 1.2.5 to 1.2.6
Refactor download cart to improve performance
…ix/fix-breadcrumbs-visual-glitch-#1196' of https://github.com/ral-facilities/datagateway into bugfix/fix-breadcrumbs-visual-glitch-#1196
…isual-glitch-#1196 Fix breadcrumbs visual glitch
…ss-#1196 #1196 - Use MUI theme background colour for breadcrumb gaps
- and don't send a notification event, as SG will do it for us if the refresh fails
#1174 - changed Title icon to Subject icon
- also tidy up code in the download button
…-error-#1257 Bugfix/fix token refresh error #1257
…button-#1261 Bugfix/disable download button #1261
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…async-2.6.4 Bump async from 2.6.3 to 2.6.4
Merge main into develop
…ors-#1210 Fix selection errors #1210
Codecov Report
@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 98.01% 97.49% -0.52%
==========================================
Files 134 134
Lines 8106 6827 -1279
Branches 2437 2055 -382
==========================================
- Hits 7945 6656 -1289
- Misses 146 155 +9
- Partials 15 16 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sam-glendenning
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release v1.1.0. You can see the format of the new CHANGELOG which is generated using github_changelog_generator. Only review the last commit as all the others are just from
developand so have already been reviewed 😅Testing instructions
Add a set up instructions describing how the reviewer should test the code