Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance System Items Table Filtering #1140

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

asuresh-code
Copy link
Contributor

Description

Enter a description of the changes here

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1039

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.99%. Comparing base (4be29b2) to head (96b2db6).
Report is 8 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/items/itemsTable.component.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
+ Coverage    98.97%   98.99%   +0.01%     
===========================================
  Files           98       99       +1     
  Lines        17736    18063     +327     
  Branches      3014     3056      +42     
===========================================
+ Hits         17554    17881     +327     
  Misses         178      178              
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@joshuadkitenge joshuadkitenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor change can you make the usage status column larger please

Copy link
Member

@rowan04 rowan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

Also note the failing test: seems to be at

style="--header-catalogueItem_name-size: 250; --col-catalogueItem_name-size: 250; --header-mrt_row_expand-size: 100; --col-mrt_row_expand-size: 100; --header-mrt_row_select-size: 60; --col-mrt_row_select-size: 60; --header-item_serial_number-size: 250; --col-item_serial_number-size: 250; --header-item_modified_time-size: 350; --col-item_modified_time-size: 350; --header-item_delivered_date-size: 350; --col-item_delivered_date-size: 350; --header-item_is_defective-size: 200; --col-item_is_defective-size: 200; --header-item_usage_status-size: 200; --col-item_usage_status-size: 200; --header-mrt_row_spacer-size: 40; --col-mrt_row_spacer-size: 40; --header-item_created_time-size: 350; --col-item_created_time-size: 350;"

@@ -1873,7 +2183,7 @@ exports[`SystemItemsTable > SystemItemsTable (normal) > renders correctly 1`] =
data-index="6"
>
<div
aria-label="Tue Sep 05 2023 23:00:00 GMT+0000 (Coordinated Universal Time),Tue Sep 05 2023 23:00:00 GMT+0000 (Coordinated Universal Time)"
aria-label=",Tue Sep 05 2023 23:00:00 GMT+0000 (Coordinated Universal Time)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aria-label=",Tue Sep 05 2023 23:00:00 GMT+0000 (Coordinated Universal Time)"
aria-label="Tue Sep 05 2023 23:00:00 GMT+0000 (Coordinated Universal Time)"

Should the comma be there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect it to be there, so I'm not sure why it does appear? It could be a follow on from the previous dates in separate divs; the snapshot might split up dates listed.

Comment on lines 223 to 225
filterVariant: COLUMN_FILTER_VARIANTS.string,
filterFn: COLUMN_FILTER_FUNCTIONS.string,
columnFilterModeOptions: COLUMN_FILTER_MODE_OPTIONS.string,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done like usage status and system id

@asuresh-code asuresh-code force-pushed the enhancement/enhance-system-items-table-filtering-#1039 branch from 0288208 to 96b2db6 Compare February 5, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Systems Items Table Filtering
3 participants