Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance System Items Table Filtering #1140

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Enhance System Items Table Filtering #1140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
331d310
added filters to systemitemstable #1039
asuresh-code Nov 25, 2024
cd721bb
Increase Usage Status Column size #1039
asuresh-code Dec 5, 2024
03dc52b
update snapshot #1039
asuresh-code Dec 17, 2024
2f5c1a4
Merge remote-tracking branch 'origin/develop' into enhancement/enhanc…
asuresh-code Dec 17, 2024
b30b720
update snapshot #1039
asuresh-code Dec 17, 2024
1c3fdfa
Update system catalogue items column filtering #1039
asuresh-code Jan 6, 2025
54f408e
merge develop #1039
asuresh-code Feb 5, 2025
96b2db6
fix failing tests related to catalogue items name introducing an extr…
asuresh-code Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/items/itemsTable.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@

const [tableRows, setTableRows] = React.useState<TableRowData[]>([]);

const noResultsTxt =
const noResultsText =
'No results found: Try adding an item by using the Add Item button on the top left of your screen';
const { data: itemsData, isLoading: isLoadingItems } = useGetItems(
undefined,
Expand Down Expand Up @@ -198,7 +198,7 @@
accessorFn: (row) =>
row.item.warranty_end_date
? new Date(row.item.warranty_end_date)
: null,
: '',

Check warning on line 201 in src/items/itemsTable.component.tsx

View check run for this annotation

Codecov / codecov/patch

src/items/itemsTable.component.tsx#L201 

Added line #L201 was not covered by tests
id: 'item.warranty_end_date',
filterVariant: COLUMN_FILTER_VARIANTS.date,
filterFn: COLUMN_FILTER_FUNCTIONS.date,
Expand All @@ -217,7 +217,7 @@
header: 'Delivered Date',
Header: TableHeaderOverflowTip,
accessorFn: (row) =>
row.item.delivered_date ? new Date(row.item.delivered_date) : null,
row.item.delivered_date ? new Date(row.item.delivered_date) : '',
id: 'item.delivered_date',
filterVariant: COLUMN_FILTER_VARIANTS.date,
filterFn: COLUMN_FILTER_FUNCTIONS.date,
Expand Down Expand Up @@ -434,7 +434,7 @@
localization: {
...MRT_Localization_EN,
...MRT_Functions_Localisation,
noRecordsToDisplay: noResultsTxt,
noRecordsToDisplay: noResultsText,
},
//State
initialState: {
Expand Down
Loading