forked from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create an inline sprite of SVGs for icons that should be styled via CSS #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
ramboz
changed the title
Improve icons
feat: create an inline sprite of SVGs for icons that should be styles via CSS
Sep 15, 2023
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
ramboz
changed the title
feat: create an inline sprite of SVGs for icons that should be styles via CSS
feat: create an inline sprite of SVGs for icons that should be styled via CSS
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an icon uses the
fill="currentcolor"
orstroke="currentcolor"
attributes, it can inherit its styling from the CSS context. To achieve this, we inline these icons and create an inline sprite to avoid repeated loading.Icons can thus be:
.icon
elementTest URLs: