Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create an inline sprite of SVGs for icons that should be styled via CSS #12

Closed
wants to merge 10 commits into from

Conversation

ramboz
Copy link
Owner

@ramboz ramboz commented Sep 15, 2023

If an icon uses the fill="currentcolor" or stroke="currentcolor" attributes, it can inherit its styling from the CSS context. To achieve this, we inline these icons and create an inline sprite to avoid repeated loading.

Icons can thus be:

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 15, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 15, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@ramboz ramboz changed the title Improve icons feat: create an inline sprite of SVGs for icons that should be styles via CSS Sep 15, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 15, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

aem-code-sync bot commented Nov 7, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@ramboz ramboz changed the title feat: create an inline sprite of SVGs for icons that should be styles via CSS feat: create an inline sprite of SVGs for icons that should be styled via CSS Nov 7, 2023
@ramboz ramboz closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant