Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill arguments to shinyWidgetOutput() and sizingPolicy() #442

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Oct 21, 2022

See the NEWS items for more details

TODO

Revert these PRs (and instead update the output containers to include fill in their function signature)

plotly/plotly.R#2192
rstudio/leaflet#822
rstudio/DT#1026

R/htmlwidgets.R Outdated Show resolved Hide resolved
@cpsievert cpsievert marked this pull request as ready for review October 24, 2022 22:30
@cpsievert cpsievert requested a review from jcheng5 October 24, 2022 22:30
NEWS.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the note I made

@cpsievert cpsievert merged commit a17dc05 into master Oct 25, 2022
@cpsievert cpsievert deleted the fill branch October 25, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants