Add fill argument to dataTableOutput()
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
requested changes
Oct 26, 2022
Co-authored-by: Yihui Xie <xie@yihui.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #1026 and instead adds a
fillargument todataTableOutput()(which gets passed tohtmlwidgets::shinyWidgetOutput()).Since #1026, ramnathv/htmlwidgets#442 got updated with a generally better way to support fill behavior htmlwidgets (it won't require changing the function signature to
height = NULL), and now, hopefully more obvious how to opt-out of that behavior if it happens to be undesirable (fill = FALSE).Happy to provide more context if you'd like.