fix(config): change styles to match with names of colorset colors #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramojus
added a commit
that referenced
this pull request
Sep 4, 2024
ramojus
added a commit
that referenced
this pull request
Sep 14, 2024
Not the best way to introduce this many changes (with one merge), but I really wanted to avoid breaking people's configs a bunch of times. The changes (every pull request has a link to migration instructions): - feat(colors): allow color overrides to override shades with predefined colors (#45) - chore(naming): rename color set to colorset (#46) - chore: remove deprecated meliora module (a9ed485) - fix(config): change styles to match with names of colorset colors (#57) - chore(config): deprecate global `neutral` option (#59) - chore(mellifluous): remove `bg_contrast` option (#60)
ramojus
added a commit
that referenced
this pull request
Nov 2, 2024
Not the best way to introduce this many changes (with one merge), but I really wanted to avoid breaking people's configs a bunch of times. The changes (every pull request has a link to migration instructions): - feat(colors): allow color overrides to override shades with predefined colors (#45) - chore(naming): rename color set to colorset (#46) - chore: remove deprecated meliora module (a9ed485) - fix(config): change styles to match with names of colorset colors (#57) - chore(config): deprecate global `neutral` option (#59) - chore(mellifluous): remove `bg_contrast` option (#60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the syntax-elements oriented styles to refer to the same syntax elements as colors with the same name in a colorset refer to.
This will make the config more consistent. Some functionality is lost, but I don't think it more important than the consistency that this change brings.
Migration