-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add breaking v1 changes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d colors (#45) * feat(colors): allow color overrides to override shades with predefined colors * add documentation * chore(ci): auto generate docs --------- Co-authored-by: ramojus <ramojus@users.noreply.github.com>
* chore(naming): rename color set to colorset * chore(ci): auto generate docs --------- Co-authored-by: ramojus <ramojus@users.noreply.github.com>
Change the syntax-elements oriented styles to refer to the same syntax elements as colors with the same name in a colorset refer to.
I had some doubts about keeping colorset specific config functionality in v1, so this commit got a bit delayed.
antoineco
added a commit
to antoineco/dotfiles
that referenced
this pull request
Sep 14, 2024
Reverts commit bac5896 The v1 branch was merged into main[1]. [1]: ramojus/mellifluous.nvim#67
ramojus
added a commit
that referenced
this pull request
Nov 2, 2024
Not the best way to introduce this many changes (with one merge), but I really wanted to avoid breaking people's configs a bunch of times. The changes (every pull request has a link to migration instructions): - feat(colors): allow color overrides to override shades with predefined colors (#45) - chore(naming): rename color set to colorset (#46) - chore: remove deprecated meliora module (a9ed485) - fix(config): change styles to match with names of colorset colors (#57) - chore(config): deprecate global `neutral` option (#59) - chore(mellifluous): remove `bg_contrast` option (#60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the best way to introduce this many changes (with one merge), but I really wanted to avoid breaking people's configs a bunch of times.
Breaking changes (every pull request has a link to migration instructions):
neutral
option (chore(config): deprecate global neutral option #59)bg_contrast
option (chore(mellifluous): removebg_contrast
option #60)