Fix return type #173
Merged
Fix return type #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramsey Could you approve the workflow so that we can see if the tests pass? Thank you 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 57 57
===========================================
Files 5 5
Lines 112 112
===========================================
Hits 112 112
|
This comment has been minimized.
This comment has been minimized.
|
It’s not useless. It tells me that the line coverage hasn’t changed as a result of your changes in this PR. 😀 |
This comment has been minimized.
This comment has been minimized.
|
@ramsey Sorry for the rant. Is there anything you would like me to change? |
Method "Doctrine\DBAL\Types\Type::getSQLDeclaration()" might add "string" as a native return type declaration in the future. Do the same in child class "Ramsey\Uuid\Doctrine\UuidBinaryType" now to avoid errors or add an explicit @return annotation to suppress this message.
|
I didn't know you can mark a comment as being "off-topic." Interesting. I'll try to get this merged soon. Thanks! |
|
@ramsey Thanks for the merge ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method "Doctrine\DBAL\Types\Type::getSQLDeclaration()" might add "string" as a native return type declaration in the future. Do the same in child class "Ramsey\Uuid\Doctrine\UuidBinaryType" now to avoid errors or add an explicit @return annotation to suppress this message.