Fix return type deprecation warnings #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
|
@ramsey is there something that should be fixed/changed within this PR? |
|
@tarlepp Thanks for the reminder. I'll merge it in and tag a release soon. |
ramsey
approved these changes
Jul 12, 2022
|
Thank you for contributing! 🎉 |
|
awesome! thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #173
Resolves #171
#173 only fixes #171 (comment) but it doesn't fix OP's issue, which is my issue as well.
Doctrine\DBAL\Types\Type::convertToPHPValue()might addmixedas a native return type declaration in the future. Do the same in child classRamsey\Uuid\Doctrine\UuidBinaryOrderedTimeTypenow to avoid errors or add an explicit@returnannotation to suppress this message.Doctrine\DBAL\Types\Type::convertToDatabaseValue()might addmixedas a native return type declaration in the future. Do the same in child classRamsey\Uuid\Doctrine\UuidBinaryOrderedTimeTypenow to avoid errors or add an explicit@returnannotation to suppress this message.