Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release memory #40

Closed
wants to merge 2 commits into from
Closed

Conversation

ibuildthecloud
Copy link
Contributor

No description provided.

Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I think https://github.com/rancher/remotedialer/pull/40/files#diff-5154df24a972eb372d2c19f34a87c4fd64beb7bca05ff3b240c269ce65239245R92 may happen too frequently and pollute the logs, so we should watch for this.

@rmweir rmweir mentioned this pull request Feb 15, 2022
@cbron
Copy link
Contributor

cbron commented Feb 18, 2022

Done in #41

@cbron cbron closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants