Memory edit #41
Merged
Memory edit #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
approved these changes
Feb 15, 2022
cbron
reviewed
Feb 16, 2022
readbuffer.go
Outdated
| @@ -60,7 +61,7 @@ func (r *readBuffer) Offer(reader io.Reader) error { | |||
| } | |||
|
|
|||
| if r.buf.Len() > MaxBuffer*2 { | |||
| logrus.Errorf("remotedialer buffer exceeded, length: %d", r.buf.Len()) | |||
| logrus.Errorf("remotedialer buffer id=%d exceeded, length: %d", r.id, r.buf.Len()) | |||
There was a problem hiding this comment.
To keep consistency with past log messages:
Suggested change
| logrus.Errorf("remotedialer buffer id=%d exceeded, length: %d", r.id, r.buf.Len()) | |
| logrus.Errorf("remotedialer buffer exceeded id=%d, length: %d", r.id, r.buf.Len()) |
This log seems more of a debug log as it's just stating that the buffer is being reset and there is nothing to indicate this is not expected or normal behavior.
cmurphy
approved these changes
Feb 17, 2022
cbron
approved these changes
Feb 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small revision of: #40
Issue:
rancher/rancher#36531