Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize creating AssetManager further #90

Merged
merged 2 commits into from
Sep 13, 2023

Flatten resources in pak headers, use specialized parsing code

5333fd4
Select commit
Loading
Failed to load commit list.
Merged

Optimize creating AssetManager further #90

Flatten resources in pak headers, use specialized parsing code
5333fd4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 13, 2023 in 1s

64.23% (-0.02%) compared to b0563d7

View this Pull Request on Codecov

64.23% (-0.02%) compared to b0563d7

Details

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.02% ⚠️

Comparison is base (b0563d7) 64.24% compared to head (5333fd4) 64.23%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   64.24%   64.23%   -0.02%     
==========================================
  Files          75       75              
  Lines        4945     4949       +4     
==========================================
+ Hits         3177     3179       +2     
- Misses       1768     1770       +2     
Files Changed Coverage Δ
src/retro_data_structures/formats/pak_wiiu.py 43.75% <ø> (ø)
src/retro_data_structures/formats/room.py 50.44% <0.00%> (-1.35%) ⬇️
src/retro_data_structures/asset_manager.py 67.14% <100.00%> (-0.19%) ⬇️
src/retro_data_structures/formats/pak_gc.py 93.97% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.